-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved lesson order. #263
Moved lesson order. #263
Conversation
Lesson order is now specified in the site-specific _config_options.yml file. Updated the top-level README to reflect this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please terminate files with a newline character.
_includes/snippets_library/ComputeCanada_Graham_slurm/_config_options.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! Thanks for propagating throughout the snippet library.
My feeling is that episode_names
should also be defined in the top-level _config.yml
. Do you have a reason not to place it there?
The top-level behavior is to run through the entire contents of _episodes in lexical order, I think, which is a reasonable default, but making it explicit probably improves legibility. The downside is that it's yet another place where the file-names are hard-coded. On balance, I favor this, and have now done it. |
Yeah... I prefer having the episode order defined explicitly at the top, then we can document changes. When the site builds on GitHub, it only uses what's in |
Lesson order is now specified in the site-specific _config_options.yml file. Updated the top-level README to reflect this. Did not actually re-order the lessons.
Closes #230.